View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0001973 | T99X171.00 SKB Eagle | SW Issue | public | 2024-07-19 15:54 | 2024-08-28 08:32 |
| Reporter | (ALTech) Younkwang Jung | Assigned To | (ALTech) Sangmin Choi | Due Date | 2024-08-21 12:00 |
| Priority | normal | Severity | s4-minor | Reproducibility | always |
| Status | closed | Resolution | reopened | ||
| Summary | 0001973: [Smart3][UI542] USB Keyboard "enter key" issue in game app | ||||
| Description | Hi Kinbay USB keyboard "enter key" that was working in OS10 But , after the OS12 upgrade, an issue was reported that the enter and numeric keys did not work. https://jira.skbroadband.com/browse/BTVV-8043 The test results are as follows. 1) OS10 ( UI541/UI540 ) - When I press the RCU OK button , keyCode is 23 07-19 16:30:29.175 3840 3929 D KeyLayoutMap: mapKey: scanCode=232, usageCode=0x00000000 ~ Result keyCode=23, outFlags=0x00000000. .. 07-19 16:30:29.175 3840 3929 D WindowManager: ====> traceKey B0, keycode=23 in interceptKeyBeforeQueueing of PhoneWindowManager.java - When I press "enter key" after connecting the USB keyboard , keycode is 23 07-19 16:32:36.086 3840 3929 D KeyLayoutMap: mapKey: scanCode=28, usageCode=0x00070028 ~ Result keyCode=23, outFlags=0x00000000. .. 07-19 16:32:36.087 3840 3929 D WindowManager: interceptKeyTq keycode=23 interactive=true keyguardActive=false policyFlags=22000000 2) OS12 ( UI542 , v15.542.130 ) - When I press the RCU OK button , keyCode is 23 07-19 16:36:35.563 3726 3831 D WindowManager: interceptSkbFuctionKeyBeforeDispatching keycode = 23 - When I press "enter key" after connecting the USB keyboard , keycode is 66 ( please check it ) 07-19 16:37:33.238 3726 3831 D WindowManager: interceptSkbFuctionKeyBeforeDispatching keycode = 66 .. 07-19 16:37:33.238 3726 3831 D WindowManager: keycode : 66 - processed. by skb function key That is, there seems to be a difference between OS10 and OS12 for Keymapping Please check it. Thank you YK.Jung | ||||
| Tags | No tags attached. | ||||
| Attach Tags | |||||
| User List |
|
|---|
|
|
Hello, Kinbay, When you press the "Enter" key using the USB keyboard, the android framework will get following keycode. OS10 : KEYCODE_DPAD_CENTER OS12 : KEYCODE_ENTER I found two point. 1. vendor/foxconn/device-profile-at100.mk # Jason, Copy Generic.kl to vendor for using keyboard in Google System image PRODUCT_COPY_FILES += device/google/atv/Generic.kl:vendor/usr/keylayout/Generic.kl Generic.kl is copied from device/google/atv/Generic.kl and this file has no Fii's modification. 2. device/amlogic/common/products/mbox/g12a/files/Generic.kl I think this file is the file which has Fii's modification. But, if you use this file, when you press the USB keyboard, you can get the keycode 0. I guess this file was generated from OS10. So, please generate the correct Generic.kl from OS12 and apply Fii's modification. If you have any question, please let me know. I will let you know the BPM ticket number soon. Thank you. Sangmin Choi. |
|
|
Hi Sangmin Thanks for your info. I am directly changing the 28 key from ENTER to DPAD_CENTER at device/google/atv/Generic.kl as shown below the patch. Double-check with the below log. --- 07-22 17:39:46.895 3825 3930 D KeyLayoutMap: mapKey: scanCode=28, usageCode=0x00070028 ~ Result keyCode=23, outFlags=0x00000000. 07-22 17:39:46.895 3825 3930 I WindowManager: interceptKeyTq keycode=23 interactive=true keyguardActive=false policyFlags=22000000 07-22 17:39:46.896 3825 3930 I WindowManager: interceptKeyTq keycode=23 interactive=true isWakeKey=false, sys.power.sleep_reason= 07-22 17:39:46.897 3825 3929 I WindowManager: interceptKeyTi keyCode=23 down=true repeatCount=0 keyguardOn=false canceled=false policyFlags=1644167168 mDeviceId=3 mSource=769 mScanCode=28 mCharacters=null 07-22 17:39:46.900 3825 3929 D WindowManager: interceptSkbFuctionKeyBeforeDispatching keycode = 23 07-22 17:39:46.900 3825 3929 D WindowManager: keycode : 23 - processed. by skb function key --- Thanks Kinbay FixEnterKey.diff (280 bytes)
diff --git a/Generic.kl b/Generic.kl index 0032d38..3b368ff 100644 --- a/Generic.kl +++ b/Generic.kl @@ -47,7 +47,7 @@ key 24 O key 25 P key 26 LEFT_BRACKET key 27 RIGHT_BRACKET -key 28 ENTER +key 28 DPAD_CENTER key 29 CTRL_LEFT key 30 A key 31 S |
|
|
Hello, Kinbay, Could you please push your modification to BFX-AT100_5.4.2_CUG branch? Please use the "[BPM-34850]" for prefix of commit message. https://jira.skbroadband.com/browse/BPM-34850 Thank you. Sangmin Choi. |
|
|
Hi Sangmin It's done. Please check it. BR, Kinbay |
|
|
Hello, Kinbay, Thank you and it should be applied non CUG branch also. I will let you know when it needs. Thank you. Sangmin Choi. |
|
|
Hello, Kinbay, Could you please apply this commit to BFX-AT100_5.4.3 branch? I didn't know it was created already. Thank you. Sangmin Choi. |
|
|
Hi Sangmin I'd pushed it to the BFX-AT100_5.4.3 branch. Please check it. BR, Kinbay |
|
|
Hello, Kinbay, Thank you, I checked it. Close this issue. Best Regards, Sangmin Choi. |
|
|
Hello, Kinbay, Could you please check is there any other key code which Fii modified at OS10 ? Why I'm asking, there is a ESCAPE key code and it was modified only for OS10. Please check if there is any difference with OS10 and OS12. device/amlogic/common $ git show b16b9505 commit b16b9505146d7e909a7977b7cc843e23c0d316d1 Author: Jason Ling <jason.tf.ling@fii-foxconn.com> Date: Wed Aug 12 18:42:54 2020 +0800 Copy Generic.kl to vendor for GSI-related testing diff --git a/products/eagle/g12a/device.mk b/products/eagle/g12a/device.mk index 36e2691..5b64ea9 100755 --- a/products/eagle/g12a/device.mk +++ b/products/eagle/g12a/device.mk @@ -40,6 +40,9 @@ PRODUCT_COPY_FILES += \ $(CHIP_DIR)/files/remote.tab3:recovery/root/sbin/remote.tab3 \ ifneq ($(TARGET_BUILD_GOOGLE_ATV), true) +PRODUCT_COPY_FILES += \ + $(CHIP_DIR)/files/Generic.kl:$(TARGET_COPY_OUT_VENDOR)/usr/keylayout/Generic.kl +else PRODUCT_COPY_FILES += \ $(CHIP_DIR)/files/Generic.kl:$(TARGET_COPY_OUT_VENDOR)/usr/keylayout/Generic.kl endif diff --git a/products/eagle/g12a/files/Generic.kl b/products/eagle/g12a/files/Generic.kl index 61d6c5b..5c7f0fa 100644 --- a/products/eagle/g12a/files/Generic.kl +++ b/products/eagle/g12a/files/Generic.kl @@ -20,7 +20,7 @@ # a new key layout file with the required keyboard configuration. # -key 1 ESCAPE +key 1 BACK key 2 1 key 3 2 key 4 3 @@ -301,7 +301,7 @@ key 318 BUTTON_THUMBR # key 352 "KEY_OK" key 353 DPAD_CENTER -# key 354 "KEY_GOTO" +key 232 DPAD_CENTER # key 355 "KEY_CLEAR" # key 356 "KEY_POWER2" # key 357 "KEY_OPTION" Thank you. Sangmin Choi. |
|
|
Hi Sangmin Is there found the issue? Or do you mean to go ahead and push it directly to OS12? BR, Kinbay |
|
|
Hello, Kinbay, SKB QA engineer raised the issue that the USB keyboard operation is different from OS10 and OS12. So, please check if there is any difference between OS10 and OS12. Is ESCAPE -> BACK the only difference now? Thank you. Sangmin Choi. |
|
|
Hi Sangmin I found one more commit to fix the GA key. SHA: 3b7fadd96 --- diff --git a/products/eagle/g12a/files/Generic.kl b/products/eagle/g12a/files/Generic.kl index 5c7f0fa..eea1c86 100644 --- a/products/eagle/g12a/files/Generic.kl +++ b/products/eagle/g12a/files/Generic.kl @@ -236,7 +236,7 @@ key 213 MUSIC # key 214 "KEY_QUESTION" key 215 ENVELOPE # key 216 "KEY_CHAT" -key 217 SEARCH +key 217 ASSIST # key 218 "KEY_CONNECT" # key 219 "KEY_FINANCE" # key 220 "KEY_SPORT" --- BR, Kinbay |
|
|
Hello, Kinbay, ASSIST was already applied at OS12. I will let you know when I need the commit of ESCAPE->BACK. Thank you. Sangmin Choi. |
|
|
Hello, Kinbay, If the ENTER changes to DPAD_CENTER, following CTS test case is failed. Module : CtsHardwareTestCases Test Case : android.hardware.input.cts.tests.MicrosoftDesignerKeyboardTest#testAllKeys I will revert this commit. commit 033bf553aabdf63ea4d8a19bf2bcfc1c092aa01d (HEAD -> 542_CUG, tag: BFX-AT100_5.4.2_CUG_2024-0820-171248, tag: BFX-AT100_5.4.2_CUG_2024-0820-165627, tag: BFX-AT100_5.4.2_CUG_2024-0816-144201, tag: BFX-AT100_5.4.2_CUG_2024-0816-143952, tag: BFX-AT100_5.4.2_CUG_2024-0814-104418, tag: BFX-AT100_5.4.2_CUG_2024-0814-104026, tag: BFX-AT100_5.4.2_CUG_2024-0813-173224, tag: BFX-AT100_5.4.2_CUG_2024-0813-172259, tag: BFX-AT100_5.4.2_CUG_2024-0810-093939, tag: BFX-AT100_5.4.2_CUG_2024-0810-093823, tag: BFX-AT100_5.4.2_CUG_2024-0809-191422, tag: BFX-AT100_5.4.2_CUG_2024-0809-190757, tag: BFX-AT100_5.4.2_CUG_2024-0802-181319, tag: BFX-AT100_5.4.2_CUG_2024-0802-181130, tag: BFX-AT100_5.4.2_CUG_2024-0802-160654, tag: BFX-AT100_5.4.2_CUG_2024-0802-160449, skb/BFX-AT100_5.4.3, skb/BFX-AT100_5.4.2_CUG, m/BFX-AT100_5.4.2_CUG) Author: Kinbay_Wu <kinbay.ty.wu@fii-foxconn.com> Date: Thu Aug 1 11:03:54 2024 +0800 [BPM-34850] [MT-1973] Modify key 28 from ENTER to DPAD_CENTER Issue Description: 1. The Enter key on the keyboard is not working. Signed-off-by: Kinbay_Wu <kinbay.ty.wu@fii-foxconn.com> Thank you. Sangmin Choi. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2024-07-19 15:54 | (ALTech) Younkwang Jung | New Issue | |
| 2024-07-19 15:54 | (ALTech) Younkwang Jung | Status | new => assigned |
| 2024-07-19 15:54 | (ALTech) Younkwang Jung | Assigned To | => (SW) Kinbay Wu |
| 2024-07-19 15:55 | (ALTech) Younkwang Jung | Issue Monitored: (ALTech) SY Yoon | |
| 2024-07-19 15:55 | (ALTech) Younkwang Jung | Issue Monitored: (ALTech) JunGyu Kim | |
| 2024-07-19 15:55 | (ALTech) Younkwang Jung | Issue Monitored: (ALTech) Jong-Hwa JUNG | |
| 2024-07-19 15:55 | (ALTech) Younkwang Jung | Issue Monitored: (ALTech) Sangmin Choi | |
| 2024-07-19 15:55 | (ALTech) Younkwang Jung | Issue Monitored: (ALTech) Wooshin Kang | |
| 2024-07-22 15:14 | (ALTech) Sangmin Choi | Note Added: 0016318 | |
| 2024-07-22 16:43 | (ALTech) Younkwang Jung | Due Date | 2024-07-22 16:48 => 2024-07-23 16:48 |
| 2024-07-22 17:26 | (SW) Kinbay Wu | Note Added: 0016319 | |
| 2024-07-22 17:26 | (SW) Kinbay Wu | File Added: FixEnterKey.diff | |
| 2024-08-01 09:59 | (ALTech) Sangmin Choi | Note Added: 0016364 | |
| 2024-08-01 11:09 | (SW) Kinbay Wu | Note Added: 0016365 | |
| 2024-08-01 12:40 | (ALTech) Sangmin Choi | Assigned To | (SW) Kinbay Wu => (ALTech) Sangmin Choi |
| 2024-08-01 12:42 | (ALTech) Sangmin Choi | Note Added: 0016366 | |
| 2024-08-01 13:15 | (ALTech) Sangmin Choi | Note Added: 0016367 | |
| 2024-08-01 13:15 | (ALTech) Sangmin Choi | Assigned To | (ALTech) Sangmin Choi => (SW) Kinbay Wu |
| 2024-08-01 13:49 | (SW) Kinbay Wu | Note Added: 0016368 | |
| 2024-08-01 14:04 | (ALTech) Sangmin Choi | Note Added: 0016369 | |
| 2024-08-01 14:04 | (ALTech) Sangmin Choi | Assigned To | (SW) Kinbay Wu => (ALTech) Sangmin Choi |
| 2024-08-01 14:04 | (ALTech) Sangmin Choi | Status | assigned => closed |
| 2024-08-01 14:04 | (ALTech) Sangmin Choi | Resolution | open => fixed |
| 2024-08-20 08:24 | (ALTech) Sangmin Choi | Assigned To | (ALTech) Sangmin Choi => (SW) Kinbay Wu |
| 2024-08-20 08:24 | (ALTech) Sangmin Choi | Status | closed => feedback |
| 2024-08-20 08:24 | (ALTech) Sangmin Choi | Resolution | fixed => reopened |
| 2024-08-20 08:24 | (ALTech) Sangmin Choi | Due Date | 2024-07-23 16:48 => 2024-08-21 12:00 |
| 2024-08-20 08:24 | (ALTech) Sangmin Choi | Note Added: 0016483 | |
| 2024-08-20 17:46 | (SW) Kinbay Wu | Note Added: 0016506 | |
| 2024-08-21 08:47 | (ALTech) Sangmin Choi | Note Added: 0016509 | |
| 2024-08-21 17:01 | (SW) Kinbay Wu | Note Added: 0016526 | |
| 2024-08-22 08:25 | (ALTech) Sangmin Choi | Note Added: 0016527 | |
| 2024-08-26 16:51 | (ALTech) Sangmin Choi | Note Added: 0016571 | |
| 2024-08-26 16:51 | (ALTech) Sangmin Choi | File Added: 스크린샷 2024-08-26 오후 5.48.58.png | |
| 2024-08-28 08:32 | (ALTech) Sangmin Choi | Assigned To | (SW) Kinbay Wu => (ALTech) Sangmin Choi |
| 2024-08-28 08:32 | (ALTech) Sangmin Choi | Status | feedback => closed |
